MrJackdaw

The problem is definitely due to the behaviour of PerformItemDrop() this does not seem to perform a true swop and can consolidate items instead. I think this is what is causing the loss behaviour we have seen.

I have uploaded to the SVN a version that *nearly* fixes the problem as it doesn't swop items if they are identical, and this seems to work, most of the time.

However, it does not fix the issue completely.

I completely recoded the plugin to use a shuttlesort, without using the LUA sort, and it worked - no item loss, perfect. BUT! I kept getting the "too busy" prompt and it would stop the plugin, meaning you had to run it 10, 20, 30 times for the pack to sort. No good.

Right now I am completly at a loss. Everything I try causes the "too busy" prompt and stops the plugin.

Sorry guys, looks like this is a loss for now.

Dammit!

For a little side project I wasn't going to spend any time on it sure has soaked up a few days!

cwsonline

I keep checking and I will test as soon as something is posted. Thank you for all your work MrJackdaw!

MrJackdaw

Spent all night working on a solution that, in theory, would work. But... I get a "You are too busy to do that right now." message and it stops the plugins.

Bugger.

MrJackdaw

That's what I was doing - however something odd happens. Will keep coding...

cwsonline

Would a solution be to compare the two items before the PerformItemDrop()? If they are the same then skip it? I think this would also eliminate the swapping of two non stackable items you see when things are already sorted.

MrJackdaw

Many thanks for the video cwsonline - Now I have a way of reproducing the bug I can try and fight it. I have had a few hours spare tonight and wrestled with all sorts of ideas.

One idea was to do a search-and-re-stack before sorting, but that didn't work if you had *full* stacks. Tried altering item weights so each weight was unique. That didn't work either.

Very frustrating.

Will keep going!

Sadly I am very busy at work right now, and obviously the maths education of my classes counts as a greater cause!

I apologise to anyone who has lost items, but as LUA Plugins are Beta (check Turbine) bugs like this are going to happen.

EDIT: The longer I look at this the less obvious the answer seems to be. It appears to be a bug with the PerformItemDrop() command. I have tried various ways of implementing the command and had no success at all - it is almost as if the program is trying to condense stacks and then deleting them due to the speed of the plugin.

EDIT TO THE EDIT!: Right, of course! The command is trying to combine slots... I have an idea!

Final Edit for tonight: Really thought I had it. Was working perfectly and not combining piles. Then... suddenly it started doing it again. Midnight now and full work for the next two days, so it will be Sunday at the earliest before I get a chance to have a look. *Swears loudly and stomps off to bed*

cwsonline

I don't think it's a problem specifically with SortPack as i've had this happen with FilterBag as well. I think it has something to do with the method of moving the items. I could be totally off but I think the items are being swapped instead of moving one item out of a slot and moving the other item in. When you have two incomplete stacks that are small enough to combine, they don't swap, which ends up causing items to be lost. If you watch my earlier clip and go to 1080 HD, you can see that there were three identical stackable items. For a split second the item count goes to 2 just before the items are destroyed. Any ideas? Thank you.

BullFrog

DO NOT use this plugin too often, since it delete items from inventory -.-

i had 3x50 pack of Shire Sweet Leaf, for fun (and for test the plugin) i made 2x25 pack +2x50 pack of leafes. And 25 pieces of leafes just disappered. And I belive its not the only item I've lost during the sort command, because magically few items disappeared from my inventry.

So use it at your own risk.


now i tried it again, just to test myself, i had 50+50+21, i made 25+25+50+21 pack, now i have only 17+50 , great plugin thanks for sharing

cwsonline

I can reproduce the item destruction pretty easily with just splitting stacks and sorting. Here is a short clip I made in Fraps. You can view it in HD if you want any more detail. This is just a brief clip I made showing a problem I have been encountering with SortPack (I have also had items disappear with FilterBag). In this clip I am running SortPack with TOBII on a fresh character. I split two stacks of items then type /sort. The items are sorted as would be expected. I then type /sort again and two of the items are destroyed.

http://www.youtube.com/watch?v=njitK8u98x8

Thank you!

cwsonline

I have definitely lost more items. When this happens I just see an empty slot or two in the bag following a sort. It just happens so fast though that I usually can't tell specifically what was lost, just that there is one less of something there. Maybe some kind of check can be performed before the swap or maybe a hundredth of a second added to slow it down a bit?

I really appreciate everyone's work on this plugin. Thank you.

MrJackdaw

Disappeared sounds odd - I will try to look at this ASAP - sadly with work the way it is that means Friday at the earliest, more likely next week. *sigh*

I can't understand it as the way the plugin works is to scan your actual pack. So, unless slots in the pack are returning incorrect info it shouldn't be able to kill items.

If it is slots returning incorrect info it is a Turbine bug...

Hazado

Yes, I also lost a few items today, it had happened just after i traded with someone. Think I lost most of the items I had traded. I bug reported it to MrJackdaw and Turbine. GM told me that the items just disappeared, they weren't destroyed or sold.

cwsonline

I can confirm that with V5 I did lose at least one item; a stack of dwarf-iron ingots. I can tell there was a problem when the sort doesn't completely move all the items but it is difficult to see what I lost. I only see this in maybe once out of 30 times or so. I am hoping that the hyphenated name had something to do with it and that V6 will be better. We will see.

Hazado

If you download from the SVN, ive got a branch going for the changes I make. I will or MrJackdaw will occasionally merge my branch with the main and push a live zip. If you can't wait just download from the svn and transfer over my branch to the main.
I only do work on the sorting aspect.

MrJackdaw

Many Thanks to Hazado for the updates!