lotrointerface.com
Search Downloads

Home Forums Downloads F.A.Q. Wiki Portals Register

Go Back   LoTROInterface > LotRO Stand-Alone Plugins > Class Specific (sub-categories) > Minstrel
Reload this Page MinstrelBuff


Post A Reply
Page 2 of 8 < 1 2 34 > Last »
Author Comments Comment Options
Unread 11-03-2011, 05:23 AM  
Eleasar
The Wary

Forum posts: 0
File comments: 13
Uploads: 0
A very hacky and not nice coded way to have fixed positions for the anthems:

Code:
function MinstrelBuffMain:RefreshEffectDisplay()
	local effectCount = EffectList:GetCount();
	local balladEffectPlace = 1;
	--local anthemEffectPlace = 1;
	--local sortedEffects = {};
	--for	i = 1, effectCount, 1 do
	--	sortedEffects[i] = EffectList:Get(i);
	--end
	--table.sort(sortedEffects, function(a,b) return a:GetStartTime() < b:GetStartTime() end);


	for i = 1, 6, 1 do
		self.BuffWindow:HideAnthem(i);
	end
	
	for	i = 1, effectCount, 1 do
		local effect = EffectList:Get(i);
		--local effect = sortedEffects[i];
		if (balladEffectPlace <= 3 and self:IsValidBalladEffect(effect:GetName())) then
			self.BuffWindow:ShowEffect(effect, balladEffectPlace);
			balladEffectPlace = balladEffectPlace + 1;
		end
		--if (anthemEffectPlace <= 6 and self:IsValidHymnEffect(effect:GetName())) then
		if (self:IsValidHymnEffect(effect:GetName())) then
			self.BuffWindow:ShowAnthem(effect, self:GetHymnEffectPosition(effect:GetName()))
			--anthemEffectPlace = anthemEffectPlace + 1;
		end

	end
	
	if (balladEffectPlace <= 3) then
		for i = balladEffectPlace, 3, 1 do
			self.BuffWindow:HideEffect(balladEffectPlace);
		end
	end
--	if (anthemEffectPlace <= 6) then
--		for i = anthemEffectPlace, 6, 1 do
--			self.BuffWindow:HideAnthem(anthemEffectPlace);
--		end
--	end
	
end

function MinstrelBuffMain:GetHymnEffectPosition(effectName)
	if (self:GetLocalization() == "en") then
		if (effectName == "Anthem of Compassion") then return 1; end
		if (effectName == "Anthem of the Third Age") then return 4; end
		if (effectName == "Anthem of the Third Age (War-speech)") then return 4; end
		if (effectName == "Anthem of the Third Age (Harmony)") then return 4; end
		if (effectName == "Anthem of the Free People") then return 5; end
		if (effectName == "Anthem of War") then return 2; end
		if (effectName == "Anthem of Composure") then return 6; end
		if (effectName == "Anthem of Prowess") then return 3; end
	else
		if (effectName == "Hymne des Mitgefühls") then return 1; end
		if (effectName == "Hymne des Dritten Zeitalters") then return 4; end
		if (effectName == "Hymne des Dritten Zeitalters (Kriegsrede)") then return 4; end
		if (effectName == "Hymne des Dritten Zeitalters (Harmonie)") then return 4; end
		if (effectName == "Hymne der freien Völker") then return 5; end
		if (effectName == "Hymne des Krieges") then return 2; end
		if (effectName == "Ballade der Selbstbeherrschung (Furchtresistenz)") then return 6; end
		if (effectName == "Hymne der Tüchtigkeit") then return 3; end
	end

	return -1;
end
I only hacked it away yesterday without knowing about LUA so there will extremely likely be much nicer ways of implementing it (iterating over the associative arrays in some for-each loop or something like that). But at least for me it does the job so thought i may as well share it.

Here is the background file i use - thanks for providing the plain background version:
http://www.2shared.com/file/Ix4hmB7Y...ground_cl.html

Maybe this helps others as well and thanks again for this really helpful plugin! With this change i am now able to put below the fixed anthem positions with kragenslots the bufff book > anthem > heal book.
Eleasar is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-03-2011, 10:33 AM  
Daeborthil
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
Thanks for the quick answer!
here are the translations

ValidBalladEffectsEn = {
["Bonus de dégâts des ballades"] = true,
["Bonus de puissance des ballades"] = true,
["Bonus de guérison de ballade (Niveau 1)"] = true
}

ValidHymnEffectsEn = {
["Hymne de sympathie"] = true,
["Hymne du Troisième Age"] = true,
["Hymne du Troisième Age (Discours de Guerre)"] = true,
["Hymne du Troisième Age (Harmonie)"] = true,
["Hymne des Peuples Libres"] = true,
["Hymne de guerre"] = true,
["Hymne aux prouesses"] = true,
["Hymne de contenance"] = true
}

I hope I got it right, the typography of the translation of the client is not very consistent. I am not sure I will manage to get into this .lua file, doesn't seem very natural, I only trust things made of wood that carry leaves....

Thank you again!
And looking forward to the quenya client for everybody :-)

Edit: after trying, I confirm that editing the .lua file was beyond my skills... I replaced the english part by the translation and get some error message when loading the file:
...ings Online\Plugins\MinstrelBuffs\MinstrelBuffWindow\Mi nstrelEffects.lua:1: '=' expected
..ne\Plugins\MinstrelBuffs\MinstrelBuffWindow\Main .lua:4: Failed to import package "MinstrelBuffs.MinstrelBuffWindow.MinstrelEffects" .

Maybe a problem with the encoding of the special characters?
Last edited by Daeborthil : 11-03-2011 at 10:49 AM.
Daeborthil is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-04-2011, 06:30 AM  
Eleasar
The Wary

Forum posts: 0
File comments: 13
Uploads: 0
@Daeborthil: You could re-download the plugin again. Then Just change the colored lines in the EN lists:

ValidBalladEffectsEn = {
["Ballad Damage Bonus"] = true,
["Bonus de puissance des ballades"] = true,
["Ballad Healing Bonus"] = true
}



ValidHymnEffectsEn = {
["Anthem of Compassion"] = true,
["Anthem of the Third Age"] = true,
["Anthem of the Third Age (War-speech)"] = true,
["Anthem of the Third Age (Harmony)"] = true,
["Anthem of the Free People"] = true,
["Anthem of War"] = true,
["Anthem of Prowess"] = true,
["Hymne de contenance"] = true
}

There are no special chars in these. The plugin still won't work fully of course but should show the ballad "Bonus de puissance des ballades" (use this ballad three times) and then hit "Hymne de contenance" - this one should show now as well. If it does not then it is some other problem. If it does - it is likely some encoding problem i would say.

For me in the German version it needs:
["Hymne der freien Völker"] = true,
instead of what is shown in the client:
["Hymne der freien Völker"] = true,
Eleasar is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-04-2011, 08:25 AM  
Daeborthil
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
@ Eleasar
I have tried what you told me, still doesn't work, probably I am not using the good tool to edit the .lua file...
Thanks anyway!
Daeborthil is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-04-2011, 09:56 AM  
Melida
The Wary
Interface Author - Click to view interfaces

Forum posts: 0
File comments: 30
Uploads: 2
Hi.
Thanks for your reply.

Could you please test this preview-version, before I upload it here at Lotrointerface?
http://sourceforge.net/projects/lotr...w.zip/download

It should detect the french client automatically. I have implemented the names you post.
I guess the error at your file is that the MinstrelBuff.lua has to be UTF8 encoded without BOM. Windows Notepad is not able to do this.
Melida is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-04-2011, 10:33 AM  
Daeborthil
The Wary

Forum posts: 0
File comments: 4
Uploads: 0
Hi
As I feared I made some typos, here is a corrected version

ValidBalladEffectsEn = {
["Bonus de dégâts des ballades"] = true,
["Bonus de puissance des ballades"] = true,
["Bonus de guérison de ballade (Niveau 1)"] = true
}

ValidHymnEffectsEn = {
["Hymne de sympathie"] = true,
["Hymne du Troisième Age"] = true,
["Hymne du Troisième Age (Discours de guerre)"] = true,
["Hymne du Troisième âge (Harmonie)"] = true,
["Hymne des Peuples Libres"] = true,
["Hymne de guerre"] = true,
["Hymne aux prouesses"] = true,
["Hymne de contenance"] = true
}

When I said the translation was not consistent.... Other than that everything works perfectly. Just another remark, the icon for the anthem of Compassion (Hymne de Sympathie) does not correspond, I have an old 3rd level ballad icon instead. Not that I use this anthem very much :-)
Thanks again for this wonderful plugin
Daeborthil is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-10-2011, 06:30 PM  
fwskateboard
The Wary

Forum posts: 0
File comments: 9
Uploads: 0
Useful plugin, thanks!

I am wondering if you could make a more compact version of this plugin? Have an option for it maybe? It is a little large for me, maybe have the buff windows smaller?

Thanks
Last edited by fwskateboard : 11-10-2011 at 06:31 PM.
fwskateboard is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-14-2011, 11:19 PM  
Koios
The Wary
 
Koios's Avatar

Forum posts: 3
File comments: 32
Uploads: 0
Quote:
Useful plugin, thanks!

I am wondering if you could make a more compact version of this plugin? Have an option for it maybe? It is a little large for me, maybe have the buff windows smaller?

Thanks
Agreed, very useful indeed! I can't imagine playing without it now

The request you have can (maybe partly) be solved very easily, by yourself. I personally didn't care much for the artwork, since I use a custom UI skin and it clashes with that one pretty strongly. So I looked into the files and found out that *included* in the download is a 'clean' version of the window, so only the effects with their backgrounds, not the parts surrounding those. I altered one line of code, to refer to that file instead of the other one and presto!

Here's what you do (make a backup BEFORE you start, as always):
1. Find the file called BuffWindow.lua (should be in .../Plugins/MinstrelBuffs/MinstrelBuffWindow/ )
2. Open it in any text editor. Find the line that reads:
Code:
self.window:SetBackground("MinstrelBuffs/MinstrelBuffWindow/Resources/minstrel_buffbar_background.tga");
If you're using an editor that displays line numbers... it's line 82.
3. Replace the entire line with this one:
Code:
self.window:SetBackground("MinstrelBuffs/MinstrelBuffWindow/Resources/minstrel_buffbar_background_clear.tga");
4. Save the file, unload all plugins and refresh them (or reboot the client, whichever you prefer).

You now have the effect windows themselves, and nothing else. For me, that's all that I needed. If you want it to be smaller than that, you'd have to change a lot more - bit too much for me to explain here and also probably best I leave that to the author
Koios is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-16-2011, 11:49 AM  
Melida
The Wary
Interface Author - Click to view interfaces

Forum posts: 0
File comments: 30
Uploads: 2
Thanks for your comments.

Since Version 1.3 you can change the background-style in the options. The "clear"-Version is excactly what it shows.
I want to thank Eleasar for providing the background with black/white anthems. I have implemented it in version 1.3 with support of fixed places, too.
Melida is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-16-2011, 05:40 PM  
Eleasar
The Wary

Forum posts: 0
File comments: 13
Uploads: 0
Glad i could help

And again - another great update to an already great plugin!

The only problem i personally have is with the plugin data storage and the german client (wonderin that you don't have this issue ^^).

It stores the values as "1,000000" instead of "1.000000" - a quick replace in that file solves the issue for me though. But maybe its just my system setup to be english Windows with German Lotro and Germany keyboard layout - not sure.
Eleasar is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-17-2011, 12:40 PM  
Melida
The Wary
Interface Author - Click to view interfaces

Forum posts: 0
File comments: 30
Uploads: 2
I did not have this error, because I am playing with the english client. But it is interesting ^^
I have some players with the german client that tests my plugin and no one found this issue.

Never heard it before but I searched around the internet and found this:
http://archive.lotrocommunity.eu/lua...g-problem.html

I think it could solve this problem. I will implement and test the suggestions in the next update.

I thank you for notifying me about this.
Melida is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-17-2011, 04:58 PM  
Eleasar
The Wary

Forum posts: 0
File comments: 13
Uploads: 0
yes there is some bug in the lua implementation - many plugins work around that with some kind of special handling it seems. But the issue can also arise as i play from different computers and sync my plugins between these. So if i am the only one safely ignore it ^^

And one more thing - in the german translation it seems the two Hymns got mixed up:

["Ballade der Selbstbeherrschung (Furchtresistenz)"] = 6,
["Hymne der Tüchtigkeit"] = 3

so change 3 with 6 works then.
Last edited by Eleasar : 11-17-2011 at 05:21 PM.
Eleasar is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-27-2011, 08:48 PM  
Bastiat1
The Wary

Forum posts: 0
File comments: 7
Uploads: 0
Great plugin, and I very much appreciate your sharing. Someone else suggested an option for a smaller display, which I agree would be useful. If you do make further changes, adding an option to make it disappear when out of combat would be helpful too.

Again, many thanks.
Bastiat1 is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-28-2011, 12:58 AM  
Eili
The Undying
 
Eili's Avatar
Interface Author - Click to view interfaces

Forum posts: 159
File comments: 177
Uploads: 13
Thank you for this great plugins.

i adapted it graphically for my suit, and i enjoy really it.


.

It is now kinda transparent on my screen and i can have it all the time on.

Thank you again
Eili is offline Report comment to moderator   Reply With Quote Reply With Quote
Unread 11-28-2011, 07:08 AM  
Planeswalker
The Wary

Forum posts: 1
File comments: 3
Uploads: 0
Hi,

thanks for this wonderful plugin!

I use the clear, no fixed positioning version with a slight twist, all the buff boxes were erased. This way it works as 'only in combat'

But still i would love to have a bar for decreasing the icon size.
Planeswalker is offline Report comment to moderator   Reply With Quote Reply With Quote
Post A Reply
Page 2 of 8 < 1 2 34 > Last »

Report problems with this file Report this File | Recommend this file to a friend Recommend this File
 
Category Jump:
Search this Category:
 

All times are GMT -5. The time now is 10:43 AM.

Contact Us - LoTROInterface - Archive - Terms of Service - Privacy Statement - Top
© MMOUI
vBulletin® - Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.

Our Network
EQInterface | EQ2Interface | Minion | WoWInterface | ESOUI | LoTROInterface | MMOUI | Swtorui