|
|
|
09-29-2019, 03:11 PM
|
|
The Wary
Forum posts: 0
File comments: 73
Uploads: 0
|
Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
Hello, i played with the plugin today to find out what cause the bug and i found the following:
not so important - you can overwrite the send to chat quickslot by draging something onto it.
Could be fixed by adding
Code:
self.chatSend.DragDrop=function()
self.chatSend:SetShortcut(chatSendShortcut)
end
to StatOverview/StatOverviewPanel.lua after line 243
important - i set the chatSendWindow Opacity to 0.5 and bgcolor to red and found out that the hidden window will apear on screen even if the plugin is minimized to icon. This is caused because minimized in the context of overview window means, that the window is minimized to titlebar.
Could be fixed by modifying if:
Code:
if (self.window ~= nil and self.window.selected == self and not self.window.minimized and not self.window:GetWantsUpdates() and self.showSendChat) and self.window:IsVisible() then
self.panel.chatSendWindow:SetSize(100,19);
end
StatOverview/StatOverviewTab.lua lines 242 - 244
since the line is quite long, for clarity, i added the following to the if:
Code:
and self.window:IsVisible()
Hopefully this will fix the bug people are seeing.
|
Oh nice, does this mean it can be fixed and an update will follow?
Last edited by Jethpriel : 09-29-2019 at 03:13 PM.
|
|
|
09-29-2019, 03:25 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
Oh nice, does this mean it can be fixed and an update will follow?
|
I still do not see the "bug". Mousing over the spot to temporarily see the report before it is sent to the chat is a feature. There is nothing sent to the chat box. So, no, there is no need for an update.
|
|
|
09-29-2019, 03:48 PM
|
|
The Undying
Forum posts: 47
File comments: 108
Uploads: 1
|
Re: Re: Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
I still do not see the "bug". Mousing over the spot to temporarily see the report before it is sent to the chat is a feature. There is nothing sent to the chat box. So, no, there is no need for an update.
|
Did you even read my post? i clearly said there how to reproduce the bug...
|
|
|
09-29-2019, 04:34 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
Did you even read my post? i clearly said there how to reproduce the bug...
|
Yes, hover over the chat button you see a preview, clicking on the chat button even when it is minimized produces the status in chat, where is the bug?
Last edited by gjpc : 09-29-2019 at 04:47 PM.
|
|
|
09-29-2019, 05:14 PM
|
|
The Undying
Forum posts: 47
File comments: 108
Uploads: 1
|
Re: Re: Re: Re: Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
Yes, hover over the chat button you see a preview, clicking on the chat button even when it is minimized produces the status in chat, where is the bug?
|
Code:
self.chatSendWindow:SetSize(100,20);
self.chatSendWindow:SetOpacity(0.5);
self.chatSendWindow:SetBackColor(Turbine.UI.Color.Red);
Yes. i gave the window size. normally its (0,0) but that doesnt change the fact that even when the window size is 0, you can however over the empty space and accidently click the send to chat button.
|
|
|
09-29-2019, 05:29 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Re: Re: Re: Re: Re: Re: Re: Results sent to chat randomly
Quote:
Yes. i gave the window size. normally its (0,0) but that doesnt change the fact that even when the window size is 0, you can however over the empty space and accidently click the send to chat button.
|
Please submit a pull request in github and I'll review it for inclusion in the next release.
|
|
|
11-23-2019, 02:35 PM
|
|
The Wary
Forum posts: 0
File comments: 73
Uploads: 0
|
Result sent to chat - hidden window
Quote:
Quote:
Yes. i gave the window size. normally its (0,0) but that doesnt change the fact that even when the window size is 0, you can however over the empty space and accidently click the send to chat button.
Please submit a pull request in github and I'll review it for inclusion in the next release.
|
How is this going - any fix?
|
|
|
11-23-2019, 02:44 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Result sent to chat - hidden window
Quote:
How is this going - any fix?
|
Dromo sent a pull request, I'll review it soon and release
|
|
|
11-26-2019, 12:58 PM
|
|
The Wary
Forum posts: 0
File comments: 73
Uploads: 0
|
Re: Re: Result sent to chat - hidden window
Quote:
Dromo sent a pull request, I'll review it soon and release
|
Thanks a lot. Looking forward to it, because it is very annoying, and I see other ppl complaining about it too.
|
|
|
11-26-2019, 05:07 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Result sent to chat - hidden window
Quote:
Thanks a lot. Looking forward to it, because it is very annoying, and I see other ppl complaining about it too.
|
Your very welcome, would you please test the new code before I release? I'll send you a zip file to test.
Last edited by gjpc : 11-26-2019 at 05:31 PM.
|
|
|
11-28-2019, 06:06 PM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Result sent to chat - hidden window
Quote:
Thanks a lot. Looking forward to it, because it is very annoying, and I see other ppl complaining about it too.
|
Well I would like to release but you and all your other people that find a "bug" that I can't reproduce very annoying will not test to see if Dromo's fix will work.
If anyone out there that see's this annoying cosmetic bug would please test. Please download http://www.circlesoft.com/images/Com...ysis.4.8.0.zip and let me know it's fixed.
Last edited by gjpc : 11-28-2019 at 06:09 PM.
|
|
|
11-29-2019, 03:34 AM
|
|
The Undying
Forum posts: 47
File comments: 108
Uploads: 1
|
Re: Re: Re: Re: Result sent to chat - hidden window
Quote:
Well I would like to release but you and all your other people that find a "bug" that I can't reproduce very annoying will not test to see if Dromo's fix will work.
If anyone out there that see's this annoying cosmetic bug would please test. Please download http://www.circlesoft.com/images/Com...ysis.4.8.0.zip and let me know it's fixed.
|
Not sure why you can't reproduce it, i personally have this bug on several computers; both linux, and multiple versions of windows.
One more attempt for instructions how to reproduce: - Load CombatAnalysis
- Open the windows
- hover your mouse over the send to chat button
- DO NOT MOVE YOUR MOUSE AFTER THIS
- type '/ca toggle' to hide CombatAnalysis (pressing / will select chat so you dont need to move mouse, alternatively you can make a shortcut for this)
- start and finish an encounter
- click with your mouse on the empty space you left it at
One more thing that comes to my mind since i have not checked z-orders, for it to work 100% , you want to make sure there are not any other UI elements under your mouse.
It might be a cosmetic bug, but it is quite annoying. I met many players ingame that accidentally spammed theyr parses in chat. I do not play lotro for as long as others so pretty much when it first happened to me, it seemed to be well known bug.
And btw it was also reported here back in 2015
Quote:
Originally Posted by Calenir
Hi there. The 'Send to Chat' button's tooltip still appears if you hover the mouse pointer over it, while Combat Analysis is minimized. Of course, it won't appear until getting into combat, but then it persists through minimization. Thanks.
|
|
|
|
11-29-2019, 10:38 AM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Re: Re: Re: Re: Re: Result sent to chat - hidden window
Quote:
It might be a cosmetic bug, but it is quite annoying. I met many players ingame that accidentally spammed theyr parses in chat. I do not play lotro for as long as others so pretty much when it first happened to me, it seemed to be well known bug.
|
Being that I still cannot reproduce the bug on two different computers and it has been around for a while I need somone to confirm that Dromo's generous fix does get rid of the problem.
Please download and test http://www.circlesoft.com/images/Com...ysis.4.8.0.zip
|
|
|
12-05-2019, 11:30 AM
|
|
The Indomitable
Forum posts: 11
File comments: 86
Uploads: 4
|
Version 4.8.0
Title says it all; waiting for the Lotro Interface gods to approve. Thanks Dromo for the button fix!
|
|
|
12-14-2019, 02:53 PM
|
|
The Wary
Forum posts: 3
File comments: 35
Uploads: 0
|
Is there a way to disable certain stats like e.g. Attacks and APS for damage?
|
|
|
All times are GMT -5. The time now is 03:44 PM.
|
|