LoTROInterface : MinstrelBuff : MinstrelBuff

		LoTROInterface > LotRO Stand-Alone Plugins > Class Specific (sub-categories) > Minstrel
MinstrelBuff

Page 7 of 8

« First

Author

Comments

Comment Options

11-04-2011, 08:25 AM

Daeborthil

The Wary

Forum posts: 0

File comments: 4

Uploads: 0

@ Eleasar
I have tried what you told me, still doesn't work, probably I am not using the good tool to edit the .lua file...
Thanks anyway!

11-04-2011, 06:30 AM

Eleasar

The Wary

Forum posts: 0

File comments: 13

Uploads: 0

@Daeborthil: You could re-download the plugin again. Then Just change the colored lines in the EN lists:

ValidBalladEffectsEn = {
["Ballad Damage Bonus"] = true,
["Bonus de puissance des ballades"] = true,
["Ballad Healing Bonus"] = true
}

ValidHymnEffectsEn = {
["Anthem of Compassion"] = true,
["Anthem of the Third Age"] = true,
["Anthem of the Third Age (War-speech)"] = true,
["Anthem of the Third Age (Harmony)"] = true,
["Anthem of the Free People"] = true,
["Anthem of War"] = true,
["Anthem of Prowess"] = true,
["Hymne de contenance"] = true
}

There are no special chars in these. The plugin still won't work fully of course but should show the ballad "Bonus de puissance des ballades" (use this ballad three times) and then hit "Hymne de contenance" - this one should show now as well. If it does not then it is some other problem. If it does - it is likely some encoding problem i would say.

For me in the German version it needs:
["Hymne der freien VÃ¶lker"] = true,
instead of what is shown in the client:
["Hymne der freien Völker"] = true,

11-03-2011, 10:33 AM

Daeborthil

The Wary

Forum posts: 0

File comments: 4

Uploads: 0

Thanks for the quick answer!
here are the translations

ValidBalladEffectsEn = {
["Bonus de dégâts des ballades"] = true,
["Bonus de puissance des ballades"] = true,
["Bonus de guérison de ballade (Niveau 1)"] = true
}

ValidHymnEffectsEn = {
["Hymne de sympathie"] = true,
["Hymne du Troisième Age"] = true,
["Hymne du Troisième Age (Discours de Guerre)"] = true,
["Hymne du Troisième Age (Harmonie)"] = true,
["Hymne des Peuples Libres"] = true,
["Hymne de guerre"] = true,
["Hymne aux prouesses"] = true,
["Hymne de contenance"] = true
}

I hope I got it right, the typography of the translation of the client is not very consistent. I am not sure I will manage to get into this .lua file, doesn't seem very natural, I only trust things made of wood that carry leaves....

Thank you again!
And looking forward to the quenya client for everybody :-)

Edit: after trying, I confirm that editing the .lua file was beyond my skills... I replaced the english part by the translation and get some error message when loading the file:
...ings Online\Plugins\MinstrelBuffs\MinstrelBuffWindow\Mi nstrelEffects.lua:1: '=' expected
..ne\Plugins\MinstrelBuffs\MinstrelBuffWindow\Main .lua:4: Failed to import package "MinstrelBuffs.MinstrelBuffWindow.MinstrelEffects" .

Maybe a problem with the encoding of the special characters?

Last edited by Daeborthil : 11-03-2011 at 10:49 AM.

11-03-2011, 05:23 AM

Eleasar

The Wary

Forum posts: 0

File comments: 13

Uploads: 0

A very hacky and not nice coded way to have fixed positions for the anthems:

Code:

function MinstrelBuffMain:RefreshEffectDisplay()
	local effectCount = EffectList:GetCount();
	local balladEffectPlace = 1;
	--local anthemEffectPlace = 1;
	--local sortedEffects = {};
	--for	i = 1, effectCount, 1 do
	--	sortedEffects[i] = EffectList:Get(i);
	--end
	--table.sort(sortedEffects, function(a,b) return a:GetStartTime() < b:GetStartTime() end);


	for i = 1, 6, 1 do
		self.BuffWindow:HideAnthem(i);
	end
	
	for	i = 1, effectCount, 1 do
		local effect = EffectList:Get(i);
		--local effect = sortedEffects[i];
		if (balladEffectPlace <= 3 and self:IsValidBalladEffect(effect:GetName())) then
			self.BuffWindow:ShowEffect(effect, balladEffectPlace);
			balladEffectPlace = balladEffectPlace + 1;
		end
		--if (anthemEffectPlace <= 6 and self:IsValidHymnEffect(effect:GetName())) then
		if (self:IsValidHymnEffect(effect:GetName())) then
			self.BuffWindow:ShowAnthem(effect, self:GetHymnEffectPosition(effect:GetName()))
			--anthemEffectPlace = anthemEffectPlace + 1;
		end

	end
	
	if (balladEffectPlace <= 3) then
		for i = balladEffectPlace, 3, 1 do
			self.BuffWindow:HideEffect(balladEffectPlace);
		end
	end
--	if (anthemEffectPlace <= 6) then
--		for i = anthemEffectPlace, 6, 1 do
--			self.BuffWindow:HideAnthem(anthemEffectPlace);
--		end
--	end
	
end

function MinstrelBuffMain:GetHymnEffectPosition(effectName)
	if (self:GetLocalization() == "en") then
		if (effectName == "Anthem of Compassion") then return 1; end
		if (effectName == "Anthem of the Third Age") then return 4; end
		if (effectName == "Anthem of the Third Age (War-speech)") then return 4; end
		if (effectName == "Anthem of the Third Age (Harmony)") then return 4; end
		if (effectName == "Anthem of the Free People") then return 5; end
		if (effectName == "Anthem of War") then return 2; end
		if (effectName == "Anthem of Composure") then return 6; end
		if (effectName == "Anthem of Prowess") then return 3; end
	else
		if (effectName == "Hymne des MitgefÃ¼hls") then return 1; end
		if (effectName == "Hymne des Dritten Zeitalters") then return 4; end
		if (effectName == "Hymne des Dritten Zeitalters (Kriegsrede)") then return 4; end
		if (effectName == "Hymne des Dritten Zeitalters (Harmonie)") then return 4; end
		if (effectName == "Hymne der freien VÃ¶lker") then return 5; end
		if (effectName == "Hymne des Krieges") then return 2; end
		if (effectName == "Ballade der Selbstbeherrschung (Furchtresistenz)") then return 6; end
		if (effectName == "Hymne der TÃ¼chtigkeit") then return 3; end
	end

	return -1;
end

I only hacked it away yesterday without knowing about LUA so there will extremely likely be much nicer ways of implementing it (iterating over the associative arrays in some for-each loop or something like that). But at least for me it does the job so thought i may as well share it.

Here is the background file i use - thanks for providing the plain background version:
http://www.2shared.com/file/Ix4hmB7Y...ground_cl.html

Maybe this helps others as well and thanks again for this really helpful plugin! With this change i am now able to put below the fixed anthem positions with kragenslots the bufff book > anthem > heal book.

11-02-2011, 11:34 AM

Melida

The Wary

Forum posts: 0

File comments: 30

Uploads: 2

Hi Daeborthil.

This is because i did not translated it to the french client.
I have to check the effect-names and I got them from the german and english client.
The file MinstrelEffects.lua contains all english and german effect names. If you replace the english names of the effects with the french one, it should work (the default-language is english). It would be nice, if you could send me the contents of the file after this, so I can implement them for all.
The active effect-names you can get with /mb list.

11-02-2011, 11:30 AM

Eleasar

The Wary

Forum posts: 0

File comments: 13

Uploads: 0

@Daeborthil:
Right now it only supports french and german client. Maybe you can help out with the correct translations for these values in frensh:

ValidBalladEffectsEn = {
["Ballad Damage Bonus"] = true,
["Ballad Power Bonus"] = true,
["Ballad Healing Bonus"] = true
}

ValidHymnEffectsEn = {
["Anthem of Compassion"] = true,
["Anthem of the Third Age"] = true,
["Anthem of the Third Age (War-speech)"] = true,
["Anthem of the Third Age (Harmony)"] = true,
["Anthem of the Free People"] = true,
["Anthem of War"] = true,
["Anthem of Prowess"] = true,
["Anthem of Composure"] = true
}

Should be exactly like it is shown under your portrait - with all these é, ê and other special characters.

11-02-2011, 10:47 AM

Daeborthil

The Wary

Forum posts: 0

File comments: 4

Uploads: 0

not working

I am afraid this one is not working for me, or is it that it is too complicated for my elvish brain... I am using the french client, I load it with /plugins charger Minstrelbuff
(charger=load on the french client) and the nice panel appears, then I get into combat, launch my ballads ans anthems, but nothing happens, did I miss something? Do I have to tell mb what buff I want him to display?
I have tried all the commands, /mb list gives indeed a list of my current buffs, /mb fr gives an error message.
I am not using any other plugin.
I am so sad, this plugin seemed so wonderful *sobs
If you have an idea...

10-30-2011, 12:54 PM

joshmiller83

Premium Member

Forum posts: 7

File comments: 32

Uploads: 0

Also would there be a way to make an option to only have the Ballad Monitoring? My wife would like to have only have ballads monitored, when she is in Watcher of Resolve or Warriors Skald Trait sets.

Last edited by joshmiller83 : 10-30-2011 at 01:00 PM.

10-30-2011, 09:32 AM

jasonspeed

The Undying

Forum posts: 29

File comments: 55

Uploads: 0

Works good now. Thanks alot.

10-30-2011, 08:33 AM

joshmiller83

Premium Member

Forum posts: 7

File comments: 32

Uploads: 0

Also FYI, Per a Turbine Dev on the forums the 9 sec CD isn't always the case. The way Ballad CDs work is they will expire within 9 secs of leaving combat, but it could be sooner. The game system checks every few seconds to see if you're in combat or not and if you aren't it removes the buffs. So if you just happen to leave combat and the game system checks for combat status and finds you out of combat it removes the buff regardless of whether its been 2 seconds or 9.

10-30-2011, 06:10 AM

Melida

The Wary

Forum posts: 0

File comments: 30

Uploads: 2

Garan I thank you much for your suggestions.
I have implemented the autodetection of the language and the safe event-handling.
On my client it now works with buffbars loaded at the same time.

10-29-2011, 02:23 PM

Garan

The Undying

Forum posts: 341

File comments: 981

Uploads: 20

Quote:

Originally Posted by jasonspeed

Edit. Found the issue I think. I tried turning off other plugins I had running incase they were causing a conflict. After I turned off BuffBars, MinstrelBuffs started working normally. Any idea why this would happen?

If the author isn't registering event handlers as a table entry but rather assigns their function directly to the event then each plugin overwrites previous plugin event handlers. There is a good discussion on the Turbine forums about how to register event handlers so that they don't clobber each other:
http://forums.lotro.com/showthread.p...nce-and-events

Last edited by Garan : 10-29-2011 at 02:24 PM.

10-29-2011, 01:10 PM

Uthboth

The Undying

Forum posts: 48

File comments: 72

Uploads: 2

I use buffbars as well and am running into the same problem as Jason.

10-29-2011, 12:25 PM

jasonspeed

The Undying

Forum posts: 29

File comments: 55

Uploads: 0

Thanks for the reply. I'm using the NA client. I tried doing /mb en just to see if it worked but it still didn't refresh the active buffs/anthems. The panel remains blank. I installed the minstrel buffs folder to my plugins directory and the MinstrelBuffs.plugin file to the minstrel buffs folder. So within the plugins directory I have minstrelbuffs folder and within that I have minstrelbuffwindow folder and minstrelbuffs.plugin file.

Edit. Found the issue I think. I tried turning off other plugins I had running incase they were causing a conflict. After I turned off BuffBars, MinstrelBuffs started working normally. Any idea why this would happen?

Last edited by jasonspeed : 10-29-2011 at 12:28 PM.

10-29-2011, 11:38 AM

Garan

The Undying

Forum posts: 341

File comments: 981

Uploads: 20

Client detection

I haven't actually looked at your plugin to see why you require the user to manually indicate the German client, but thought you might be interested in how to programatically detect the client language, as discussed on the Turbine forum thread: http://forums.lotro.com/showthread.p...uage-Detection

Code:

   _locale = "en";
    if Turbine.Shell.IsCommand("hilfe") then
        _locale = "de";
    elseif Turbine.Shell.IsCommand("aide") then
        _locale = "fr";
    end

Page 7 of 8

« First

Report this File | Recommend this file to a friend

Recommend this File

Search this Category:

All times are GMT -5. The time now is 03:22 PM.