You're awesome! I spent hours yesterday looking through the code and that didn't stand out to me at all. I'll test this right away!
Just FYI, copying something I posted over on SSG's forums:
----- ----- ----- ----- -----
I have completed testing with all classes and I have noted this error with the Captain skill Motivating Speech/Improved Motivating Speech. I am
not seeing this error with Telling Mark or Oathbreaker's Shame, most likely because these are debuffs on an enemy unit and not buffs on the casting character or the casting character's allies.
I have been as thorough as possible with my testing and I am seeing this issue with BuffBars only with the Mariner skill Motivating Song and its associated buff Motivated, and with the Captain skill Motivating Speech/Improved Motivating Speech and its associated buff Motivated (identical in name and effect to the buff applied by the Mariner skill).
Note that the buff In Defense of Middle-earth which is also applied by the Improved Motivating Speech skill does get properly displayed by BuffBars and does not appear to be contributing to any issues with the plugin.
So it does appear to be related to the change made in u39.1.2:
Quote:
Several Captain skill effects have been incorrectly stacking with similar effects from other classes that are meant to be mutually exclusive. These have been cleaned up, and should no longer stack, as expected. This includes Telling Mark & Marked Foes (Mariner), as well as Oathbreakers Shame, which was able to stack with The Breaking of Thangorodrim (Mariner) or Murder of Crows (Lore-master).
|
----- ----- ----- ----- -----