Evereus

Hi Homeo,

i've got a question concerning your plugins and especially Altholics. I have approximately 10 different ones installed.
Every plugin of you has a separate icon, which i can move to the place i want it to be.
But every time i leave the game and relogg, most of the icons are no more on the place i moved them before.
Sometimes only 1 cm beside the old position.
What can i do to fix them on the position i moved the icon ? Is there a possibility, perhaps something in the options to fix the position/not moving the icons after gamestart/relogg ?
Would be great if you have a suggestion/solution.

Kind regards and many thanks for your patient and work !

Eolath

kendaron

I see you store combined character inventory data in individual settings file. It would perhaps be better to save them individually and have a file with the master list of characters so you know the file names.

Then when a search happens over all characters you load the corresponding files then. Otherwise you only keep the current character inventory data in memory and save on logout.

But that is an optimisation to reduce memory and needing to always save bag data when you are out adventuring. I know refactoring can be a pain.

Thanks for listening to my comments!

homeopatix

Hello,

yes i think this is the way a should do it, i will
work on that this week-end and will propose you with an update
on next week

to be able to see the right bag at any time

thank you for your time, i really apreciate

Homeo

kendaron

I think you can use the GetGameTime and SetWantsUpdates functions to do it. When inventory is changed, if it is not already enabled, you SetWantsUpdates(true) and set a global variable to say, 3 seconds. And using the GetGameTime within the Update function you reduce the global variable by 1 after each second. If inventory changes again before it reaches 0 you increase the global variable back to 3. When the Update function hits 0 you disable SetWantsUpdates and save.

Thats how I think it will work. I dont recall if it actually had a timer event to use.

EDIT: Actually, why not just save on logout?

homeopatix

Hello,

everything is working fine for me, i will do a few more check and let you know what is happening

thank you for the feed back

Homeo

EDIT :

the think is that when 1 item get in the bag, the function lunched
If you have 3 items getting in the bag, the function is lunching three time

that is how lotro is working,
i will find a way to solve that prob...

but there is not much used of machine ressources to save the bag, even if the bag is almost full

but i will found out a way to do that...

thank you for your help in this

Homeo

kendaron

I am running 2.56 but am not seeing a difference? When I mine I might get one or two items and AltHolic reports 'BackPack Saved' immediately. And usually multiple times, like previous versions.

Here is a link to my chat window showing it after mining:

https://imgur.com/a/B7GWgL1

kendaron

Woo hoo. Looking forward to trying it!

homeopatix

Hello,

i am saving 30 second after the inventory change only if the inventory change
and only if not in combat

Homeo

kendaron

Hi, are you actually saving every 30 seconds? or 30 seconds after the last inventory change? Because if it is every 30 seconds that is way overkill and not necessary. A timeout/counter only needs to be set/reset when a change is detected. If nothing has changed, no need to save!

Cheers

homeopatix

Hello,

tank you for you comment and your advice, i will work on that asap

Homeo


EDIT:
I have done all the updated that you asked me
and set a timer to save the datas every 30 sec
added a check to save only if not in combat


Homeo

kendaron

Hi Again,

1) When you expand your list of characters and hover the mouse of the crafting icon, the popup that displays is often shown off the bottom of the screen. This happens with characters at the bottom of the list (I have a lot of characters across worlds!). Needs to be prevented from being partially off screen.

2) There is some funny things going on with when you save bag data. I have the save and load notifications checked. Sometimes when I logon I immediately see my bags being saved something like 12 times! The only thing I can think of is that the subscriber jug and town services items have disappeared triggering the saves. Not sure why it would be doing it like 12 times!

Also, sometimes when I receive mulitple items (like from mining, looting corpses chest etc) it triggers the save for each item. And sometimes far more times than items received! Similar to the login problem, I might mine and get 2 items and it saves 6 times!

As a suggestion, if you have not already, add a 'debounce' function. This is a countdown/timer that is triggered whenever you need to save bag data. When the timer is reached it saves the bag data. Every time you receive a notification that the bags have changed you reset the timer. So if the timer is set for 2 seconds, and you receive multiple items, you reset the timer each time, and after the final item is received, 2 seconds later the bags will be saved.

Additionally, only save in this function if you are not in combat. The reason I say this is each save (when you have a lot of bag info) can cause a momentary freeze in the game client, and you do not want that in combat! Also implementing the debounce function will help minimise that too.

Cheers!

homeopatix

Thank you,
i really appreciate this

Homeo

Evereus

I updated to 2.54 and everything is fine now !
For me, it works !
Thanks for your fantastic work !!

homeopatix

Hello, i did a few test and could reproduce the probleme when in 800x600

i did some update please let me know what happends, the probleme should be solved in the V2.54

By the way thank you for the time you took to help me found out the probleme

Homeo

FOR DRONO

i did some updates but not yet in the money window, have a check that should solved your probleme

Homeo

Evereus

Hi Homeo,

i checked it again as you wrote - behaviour still the same...
I filmed it with my camera to show you how it looks like - it's a bit difficult to describe...

https://www.directupload.net/file/d/...kk9d8g_mp4.htm

Perhaps you can imagine, what's wrong...

Many thanks !