Astleigh

Posting a note to let people know that Lyrical 1.4 should continue to work in Rise of Isengard.

Astleigh

Hello Zedrock,

I looked at that patch, and it is an almost identical fix for the french/german savefile bug which was added in Lyrical 1.4. (It changes the savefile indexes to strings instead of numbers.)

Are you saying that you tried 1.4 and savefiles still did not work, but after applying this patch it did?

Are you having the problem Lya did where savefiles are simply not being generated?

Thanks for the feedback!

zedrock

Hello, Astleigh

I'm french user of your incredible (^^) Lyrical plugin. So thanks for it.

About the savedata failing in German and French locales :

After much google's research, i found something that has worked on my French Client.

A french guy has rewritten a piece of your code at the begining.
You can look that here :

Member : Mierin
Post at : 21-11-2010 11:01:37

http://dragon.eteint.free.fr/forum/v....php?pid=20887

I made the change. It works very well.

Wait and See

* if you need a help for translating, MP me
* sorry for my poor google's english

Astleigh

I found out why your edited plugindata doesn't work. It seems to have a UTF-8 BOM prepended which is confusing the parser. I was able to load it after deleting the BOM.

Yes, and it still works fine for me.

You don't need the beta lua plugins. Only reason I asked is because they have caused problems in the past with lyrical.

Lya

Mmh, I could save two of those (one with the bug, the other without).

http://dl.free.fr/h3OPxND9z the .bak is the one which doesn't work.

Did you put your game in french langage to test ?

I also tryied without any other plugin activated, same bug. And I still cannot edit my text or add one with the new file :/ .

I don't use the beta lua. Do you think I should try ?

Astleigh

Sorry Lya, I still can't reproduce the problem you are seeing.

Can you send me the plugindata files you saved, specifically the one that caused the loading error?

Did you install the turbine Beta_LuaPlugins.7z in your Plugins folder? (It looks like "..\Plugins\Turbine" and has a bunch of extra lua files) If you have this folder, can you try temporarily moving it somewhere else and retrying?

Do any of your other plugins have problems saving their plugindata files?

Lya

OK, seems that my answer will be long for giving you all what you need.

What I tried :
- Delete everything (folder + plugindata file), download the new one (3 times, thought I had a problem with the archive), install the new plugins, launch with /plugins charger lyrical (load).
-> No problem at this moment, it works fine.
- Put 2 of my texts in the plugins and made many tests :
Quit the game -> Sometimes the lyrical.plugindata has been created, sometimes not.
Changing toon -> Never been created.
Using command /plugins vider (for stop every plugins) -> Never been created
Using command /rl with Plugin Manager (for reload every plugins at once) -> Never been created.
Actually, it's been 4 days that this file doesn't want to show itself (never been created). I had a look on my windows permissions, there's no problem here.

When I got the chance to have a plugindata, I kept some of the for made some test.
I tryed to have a look to the file and how it's created. I always opened it with notepad+ (So I don't have any encoding problem) even if I change one letter, the plugins doesn't lauch and have this error :

One of the lyrics :

There are some accent (I'm french), perhaps it's a problem ? Perhaps not, if it was I think the file would never been created..


Copies of lyrical.plugindata files such as: one generated by default right after lyrical loaded the first time
That's my problem, the file NEVER has been created at this moment, each time it's ALWAYS when I quit the game and not each time.
I think the problem is here. And when the file is created I never can edit the texts, it always come back as the first save.


Others plugins installed :
Plugin manager
Songbook
Bigpack
Buffbars
Palantir
Tonicbars


Thanks for your help ! I hope you have all what you need, I'm ready to make some of the tests you want ! (And sorry for the bad english !)

Astleigh

Hi Lya,

It sounds like you found a bug, but I need your help to fix it since lyrical is working fine for me and I don't know what is triggering the problems you are seeing. Here are some things that would help me:

* Very detailed instructions on what you tried, and what went wrong (eg. 1. Delete plugins/astleigh directory, 2. unzip lyrical-1.4.zip, 3. load lyrical in LOTRO with /plugins load lyrical, etc...)
* Copy of some of the lyrics texts you are trying to load
* Copies of lyrical.plugindata files such as: one generated by default right after lyrical loaded the first time, one generated after trying to save a new song, your "edited" plugindata file that didn't work
* Copy of any error messages you see
* Info on what other plugins you have installed

If some things are too big to paste here, you can also email me at: <[email protected]>

Lya

Hi there,

I tryed many time to use this plugins but I still have many problems with it.
My client is french and I was using 1.3 version. When I saw that the save problem was corrected in the 1.4 version, I put all my texts in a .txt files and changed the plugins (and delete lyrical.plugindata).

Now, those are my problems :
- First, I couldn't saved any text. The lyrical.plugindata doesn't want to show himself (no file anywere).
- Sometimes, I can save my texts BUT I cannot edit them after, if the file has been created once, I cannot save any other text or make any modification.
- It's impossible to edit manually the plugindata : I cannot launch the plugin after, juste have an error.

So, each time I want to change a text or add one, I have to delete the plugindata files and cross my fingers so the new file will be created. It's been 2 days I'm trying to have a new one without any success.

I there is something I'm doing wrong ? Can anybody save me ?

Toùmi

Big Grats !!
It's perfect now!

Astleigh

Did you delete your old Lyrical.plugindata before loading v1.4?

Tinidril

I could not get v1.4 to work for me, so I installed v1.3 since I do not actually need French/German client support. Here is the error I kept getting when attempting to load Lyrical with v1.4:

...Rings Online\Plugins\Astleigh\Lyrical\MainWindow.lua:46: 'for' limit must be a number

Glenwin

Dear Astleigh,

I HERBY DECLARE: YOU ARE THE HERO FOR ALL EU MUSICIANS AND SINGERS IN LOTRO!
It now works perfectly on EU clients.
(There are no more comma's involved in the stored numbers so they cannot
lead to a parsing error any more. This now works on every client.)

So that you know: I've re-set the number format of my OS to German
standard again and there is no problem whatsoever. I tried each and every
function of the plugin and it's OK. If one ignores he/she has to delete or
rename the old plugin.plugindata file and start over from scratch with the
content.

But: That for us is now as easy as it was for the US players: just click NEW
then EDIT, paste your Text (or type it) and click SAVE.


This is so great and I thank you for your unbelievable quick reply and this 1.4 release.

Thank you so much!!

kind regards
Glenwin from EU-RP Belegaer Server

Astleigh

Guten tag, Glenwin from Germany!

Thank you for your clear explanation of the problem and a suggested workaround. I saw discussion of this issue on the forums but I didn't quite understand what the solution was.

I've updated Lyrical to 1.4 with your suggested changes, but I don't have a German client so I can't fully test whether it works. It didn't appear to break anything in the English client, although its incompatible with the old savefiles, so I had to delete my Lyrical.plugindata.

Please let me know if this fixes your problem!

Astleigh

Glenwin

Hello Astleigh...

so... I have made an error. I disregarded the window-propteries in the plugindata file:

e.g:

["size"] =
{
["height"] = 400.000000,
["width"] = 400.000000
},
["page"] = 8.000000,
["position"] =
{
["left"] = 1848.000000,
["top"] = 650.000000
}


would become


["size"] =
{
["height"] = 400,000000,
["width"] = 400,000000
},
["page"] = 8,000000,
["position"] =
{
["left"] = 1848,000000,
["top"] = 650,000000
}

and would cause the same problems. So the size and position stored as strings, too would solve the problem. Or there might be another way (maybe built directly into LUA) to get the addon to be aware of the country's number settings. If I had to decide, I would go with integers stored as strings like this:

["size"] =
{
["height"] = "400",
["width"] = "400"
},
["page"] = "8",
["position"] =
{
["left"] = "1848",
["top"] = "650"
}

(I assume the size and position is stored in "pixel" units)

regards
Glenwin