MrJackdaw

/stack or use the button at the top left of your bag and select "stack"

Ralphtro, sciurpadrun - Turbine have yet again added lots of items to the game without adding them to the enumeration. Annoys me deeply. However, I know they are overworked there right now - so it's absolutely fine!

I am in the process of doing some work on Bevy and then I will have a look here for you.

Rymanor

First off, I am a long time user of another bag plugin, and recently found this one. Needless to say, I have converted. Nonetheless, there is on function I would like to see: merging.

The bag sometimes will not merge items of the same type together. Is there some way around this? Would it be difficult to merge items automatically? Or with a button press?

I admit I have zero programming knowledge. Hope someone can figure this out.

ralphtro

Can someone else try this too? It seems to work for me.

In sort.lua, I renamed the swop funciton to oldswop and added this as the last lines..

It seems to work fine, although I'm seeing a few strange graphic artifacts that I believe are just due to the API (wrong items flickering) although it's always possible I made a mistake.

The basic idea is that it's quicker to place the out of piece item at the very end instead of doing the swap. This seems to be faster then using the LUA function to me anyway, although I havent' done rigorous testing. It also should make a few more cases where it puts an item into an empty slot which seems to be faster than swapping.

In their defense, since a swap involves two items, it is a lot more difficult to ensure that nothing gets lost or duplicated. Splitting this makes for two simpler operations.

An optimization would be to split the two backpack:PerformItemDrop so they act on different iterations so that the UI could grab control between them, but that's too much thought for me right now, I want to see if this method is faster and works before fixing it further.

Code starts here.


function swop(src,dest)
if backpack:GetItem(dest)==backpack:GetItem(src) then return end

itemdest=backpack:GetItem(dest)
itemsrc=backpack:GetItem(src)

if itemdest~=nil then
lastitem=-1
for l=size,dest+1,-1 do
if backpack:GetItem(l)==nil then
lastitem=l
break
end
end
if lastitem~=-1 then
backpack:PerformItemDrop(itemsrc,lastitem, false)
backpack:PerformItemDrop(itemdest,src, false)
--Turbine.Shell.WriteLine("<rgb=#888888>Swop S:"..src.." D:"..dest.." L:"..lastitem)
return
end
end

if itemsrc~=nil then
backpack:PerformItemDrop(itemsrc,dest, false)
return
end

Turbine.Shell.WriteLine("<rgb=#888888>Should never be seen. Error in Swop function.")
Timer:SetWantsUpdates(false)
Timer:Start()
end

Vald

It was working fine until today, now I get the following message:

Starting sort
Sort Started
...Online\Plugins\JackdawPlugins\SortPack\Function s.lua:98: attempt to perform arithmetic on global 'CatWeight' (a nil value)

I'm level 84, so it may be some piece of Rohan equipment.

sciurpadrun

Hello hello MrJackdaw, this message popped up after sorting.

The item in slot 68 has not been given category text OR itemInfo by Turbine. Dammit. It's number is 212 Please inform MrJackdaw!

Keepup the good work, and thanks per this plugin

ralphtro

We're missing this category in the code. I believe that everyone can add it using the UI until the code gets updated.

I also dragged the bridle down into weapons so that it would sort with the LIs, which is better (for me) I don't know how you can do that in code, or whether it's a good idea.

BTW, still loving this plugin, thanks!

List.LUA, Line 41
ItemCategory[218]="Bridle" --Thanks ralphtro

Radnof

I am a 1st time user of plug-ins and followed the installation instructions but when I load a character I get these messages...

...s Online\Plugins\Deusdictum\UI\DeltaButtonWindow.lua :8: attempt to call global 'class' (a nil value)
... Online\Plugins\Deusdictum\UI\DeltaButtonControl.lu a:8: attempt to call global 'class' (a nil value)
...f the Rings Online\Plugins\Deusdictum\UI\Dragbar.lua:39: attempt to call global 'class' (a nil value)
.f the Rings Online\Plugins\Deusdictum\UI\Dragbar.lua:39: attempt to call global 'class' (a nil value)

I have since added other plug-ins and they work just fine. I have all the expansions except RoR (I mention that due the the Bridle issue in previous posts) and have unloaded, uninstalled, re-installed and still have these errors. any help would be appreciated.

MrJackdaw

Fixed the missing Bridle bug. Why no item info Turbine?

sciurpadrun

Downloaded the new version, and I still get an error. I tried removing the bridles from my bags but still getting error. I guess I'll live with that hot mess that are my bags now, until you have time to fix it.

EDIT: well, I tried sorting again and, now for some reason, it works

Maevine

Thank you so much. I have modified the file and all is ok.

Congratulations

MrJackdaw

Thanks Ralphtro. When I finally GET a bridle I'll see what I can do about this!

ralphtro

It's a Turbine bug.

You can brute force around the error by doing this. It seems to be more erratic in it's sorting now, though. I don't know if it's just my perception, or if Turbina is doing something different with it's output now.

Open functions.lua in Notepad and turn on the status line so you know the line number.

if warned.Category==nil then
if itemInfo == nil then
else
Turbine.Shell.WriteLine("<rgb=#888888>"..itemInfo: GetName().." has not been given category text by Turbine. Dammit. It's number is "..Category.." Please inform MrJackdaw!")
warned.Category=true
end
end

instead of

if warned.Category==nil then
Turbine.Shell.WriteLine("<rgb=#888888>"..itemInfo: GetName().." has not been given category text by Turbine. Dammit. It's number is "..Category.." Please inform MrJackdaw!")
warned.Category=true
end

in Functions.lua line 88.

MrJackdaw

Dear Users,

Version 160 is experimental at best - I have had no time to really work on the plugin. May I suggest you back up your settings before use.

Will hopefully deal with all the bugs. *Fingers crossed*

I have only had minutes, and I mean minutes, to test this.

Hoping to get some real time in before the end of the month.

Sorry for the inconvenience.

Vald

I think that may be what's causing my problem, as well. I need the bridle in my bag, so is there a simple lua file edit we can make to fix this?

dbjordan

Everything worked fine until I received my first legendary bridle item in my pack. I took the bridle out of my pack, put it in the vault. SortPack works again!